Add errors for Matrix ± AbstractJuMPScalar #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
reviewed
Nov 2, 2023
blegat
reviewed
Nov 2, 2023
|
Looks good to me, just need tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3557 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 37 37
Lines 5602 5608 +6
=======================================
+ Hits 5501 5507 +6
Misses 101 101
☔ View full report in Codecov by Sentry. |
odow
reviewed
Nov 2, 2023
odow
reviewed
Nov 2, 2023
odow
reviewed
Nov 2, 2023
odow
reviewed
Nov 2, 2023
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
|
Let's just double check with https://github.com/jump-dev/JuMP.jl/actions/runs/6738331476 (cc @mortenpi, here's an example where this is useful) |
odow
approved these changes
Nov 2, 2023
|
We can do separately, but with a slight tweak, this could also fix #3554 They're essentially the same problem. |
|
If this OK to merge? What's the thing about actions and Morten? |
|
LGTM. The Morten thing is JuliaDocs/Documenter.jl#2323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a more informative error when there an operation between a single JuMP variable and a Matrix type object is attempted.
Closes #3553